-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject toml #1246
Add pyproject toml #1246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 192 192
Lines 11900 11900
=======================================
Hits 10317 10317
Misses 1583 1583 Continue to review full report at Codecov.
|
Should we put any other config in there while we're at it? Like |
I guess this can eventually replace setup.py, but it seems like the features are not all there yet (installing in developer mode for example). I wonder if conda will support it eventually? Right now, I build the conda package in a pretty automated fashion, reading the necessary info from setup.py, but that will break I guess if we go full PEP 517 |
There is no "full" pep 517. You need a build system. You can now specify that build system in the pyproject.toml. But you still have to choose |
I added the black config |
What I meant was this quote here from the article above:
Right now we have a mix of setup.py, setup.cfg, and pyproject.toml. But I guess that's fine for now. |
Ah ok. But we probably want to keep the automatic versioning, right? So that needs a script, not just a config. |
Does this address #1159? |
@watsonjj right now, it just adds a config, it does not run black by itself |
Reference for pyproject.toml and why we should have one:
https://www.python.org/dev/peps/pep-0518/
https://www.python.org/dev/peps/pep-0517/
https://snarky.ca/what-the-heck-is-pyproject-toml/