-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change actions for mamba / pip install methods. #2207
Conversation
7f02e7e
to
1a9438e
Compare
Should we also update the installation instruction in the README and use mamba instead of conda? |
3fe4ae4
to
401542a
Compare
for mamba: use mamba-org/provision-with-micromamba for pip: use actions/setup-python
401542a
to
37c3768
Compare
Eventually, mamba won't be needed explicitly as the mamba solver will be included in a future version of conda (I think it's experimentally there already), but for now I think it's fine to just recommend mamba, as we know that installing packages from conda-forge with conda can be a slow nightmare due. |
I think we should always prefer recommending the open-source builds by conda-forge / mamba over the closed source (binary) blob packages by Anaconda Inc. |
I also update codecov here, instead of #2206. I think it is reasonable to have this in a single PR. |
There has been a new matplotlib release yesterday (3.6.3), that the pip install uses, but mamba does not. |
seems they have change the behavior of how vmin/vmax are calculated such that it breaks if there are NaN or Inf values? The test is failing when setting a CameraDisplay to log-scale, which will cause NaNs for any negative value (but that was not an issue in the past). Could also be a side effect from something in numpy |
for mamba: use mamba-org/provision-with-micromamba
for pip: use actions/setup-python