-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run test only if labels don't contain 'documentation' #2227
Conversation
Maybe |
f82b6f4
to
1f7346b
Compare
I rebased onto the latest main. If this builds, we can merge |
I gave it another go, tried a different syntax for the conditional to see if that caused the tests to be marked as skipped instead of succeeded as promised by the GitHub docs. I even removed the "documentation" label, which I really tough should ensure the tests are not skipped, but still get get marked as skipped and thus this will be stuck forever. |
@kosack @nbiederbeck @maxnoe I finally figured out what the problem was: there's a bug/design error in how required steps interact with matrix jobs and the conditional check: I've now implemented one of the two cludges proposed to get around this: put if gates into mostly every substep of the "test" workflow. |
👍 on The changes itself look fine to me. It is a bit confusing, that the skipped tests still show up in the list of checks, but its anyway helpful. |
Changed the magic label to |
@maxnoe This could finally be merged once the doctests pass, but I don't really understand why they fail. Help! |
Fix #2226