Fix deprecation warning due to pkg_resources #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…annot do anything about
maxnoe
force-pushed
the
disable_deprecation_warning_error
branch
from
5134f7f
to
2b556df
Compare
kosack
approved these changes
Feb 15, 2023
|
This just needs a description explaining why the changes are needed (something like an answer to why did this have to be fixed at all) and then I can approve :) |
Tobychev
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated in general and importlib.{resources,metadata} designed to replace it.
Recently, just importing pkg_resources raises a
DeprecationWarning.This also replaces an external dependency with using python's stdlib (or a backport for older versions that do not yet have everything we need)