Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove no-longer needed importlib_resources #2389

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Remove no-longer needed importlib_resources #2389

merged 1 commit into from
Aug 31, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Aug 31, 2023

Leftover cleanup from #2342

@HealthyPear
Copy link
Member

There is code also in ctapipe/core/plugins.py and ctapipe/tools/utils.py

@maxnoe
Copy link
Member Author

maxnoe commented Aug 31, 2023

There is code also in ctapipe/core/plugins.py and ctapipe/tools/utils.py

That's using importlib{,_}metadata, not resources. And for metadata, the backfill is still needed until we also drop 3.9

@maxnoe maxnoe merged commit 45bf408 into main Aug 31, 2023
12 of 14 checks passed
@maxnoe maxnoe deleted the importlib_cleanup branch August 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobychev Tobychev Tobychev approved these changes

@kosack kosack kosack approved these changes

@nbiederbeck nbiederbeck Awaiting requested review from nbiederbeck

Assignees
No one assigned
Labels
maintenance no-changelog-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxnoe @HealthyPear @Tobychev @kosack