-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty reference location #2402
Fix empty reference location #2402
Conversation
Would it be possible to add a test that checks "proper" initialisation when metadata is missing? |
This makes me realize that we don't have a test that checks the interface of all installed EventSources. It's not so easy to do though, as you would need the right inputs for each one. But it would be good to have a way to verify that an EventSource plugin creates all the necessary attributes |
|
||
self._subarray_info = self.prepare_subarray_info( | ||
self.file_.telescope_descriptions, self.file_.header | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for this move?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it needs to come after parse_simulation_header, otherwise I can't use the SimulationConfigurationContainer
Docs failure is fixed in main, please rebase |
One of the example notebooks no fails because it tries to print a subarray without a reference location:
|
5b3c93e
to
a4ddd35
Compare
Seems it was |
Should be Null Island
before you could construct a SubarrayDescription without any attributes, but that's not at all useful
a6fdd43
to
ef29550
Compare
This adds a fallback dummy location to subarray.reference_location if the metadata in the simtel file doesn't exist. The dummy location is on "null island" (lat=0, lon=0), but at the correct height as read from the simulation_config.
This was a problem for pre-Prod6 files, which didn't contain the metadata necessary to determine the reference location.