Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix h_max definition #2403

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Fix h_max definition #2403

merged 14 commits into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. make definition of h_max consistent

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ce28ea2 View commit details
    Browse the repository at this point in the history

  2. get tests to run

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d292adc View commit details
    Browse the repository at this point in the history

  3. revert change to conftest for now

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    258a98f View commit details
    Browse the repository at this point in the history

  4. deal with case where there is no reference_location 

    Will be fixed in another PR (should always have at least the observatory height)
    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5d742be View commit details
    Browse the repository at this point in the history

  5. removed checks for reference_location (not needed)

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b26add8 View commit details
    Browse the repository at this point in the history

  6. added initial changelog

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    64426e4 View commit details
    Browse the repository at this point in the history

  7. remove one more redundant check for reference loc

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    755eeed View commit details
    Browse the repository at this point in the history

  8. fix bug where return value was incorrect 

    Returning None here would cause an exception, since the values are
unpacked into a 4-tuple
    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    604fe72 View commit details
    Browse the repository at this point in the history

  9. better description of h_max

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9675cc6 View commit details
    Browse the repository at this point in the history

  10. fix doctring format

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c2bef1b View commit details
    Browse the repository at this point in the history

  11. use relative references in changelog

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    3c9bd5b View commit details
    Browse the repository at this point in the history

  12. fixed phrasing

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    7250552 View commit details
    Browse the repository at this point in the history

  13. define magic number

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ad401fc View commit details
    Browse the repository at this point in the history

  14. use np.average

    @kosack
    kosack committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    9a1494f View commit details
    Browse the repository at this point in the history