Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor issues found by sonarqube #2466

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Fix some minor issues found by sonarqube #2466

merged 3 commits into from
Jan 4, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 20, 2023

  • Use https where possible
  • Use NamedTemporaryFile instead of mktemp

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c05b493) 92.47% compared to head (30fd288) 92.47%.
Report is 2 commits behind head on main.

Files Patch % Lines
ctapipe/visualization/bokeh.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2466      +/-   ##
==========================================
- Coverage   92.47%   92.47%   -0.01%     
==========================================
  Files         234      234              
  Lines       19816    19817       +1     
==========================================
  Hits        18325    18325              
- Misses       1491     1492       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tobychev
Tobychev previously approved these changes Nov 20, 2023
@maxnoe maxnoe merged commit 6ffc12d into main Jan 4, 2024
11 of 14 checks passed
@maxnoe maxnoe deleted the sonarqube_fixes branch January 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants