Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI after pytest-xdist update #2469

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix CI after pytest-xdist update #2469

merged 1 commit into from
Nov 22, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 22, 2023

The new version 3.5 of pytest-xdist was released yesterday changing the order in which tests are run:

now sorts scopes by number of tests to assign largest scopes early – in many cases this should improve overall test session running time, as there is less chance of a large scope being left to be processed near the end of the session, leaving other workers idle.

This lead to the Provenance tests failing due to the nature of this singleton (it contained the provenance of all applications run prior to the provenance test) not only the ones being tested for.

Fixed by monkeypatching the provenance back to an empty state for the tests.

@maxnoe maxnoe changed the title dummy Fix CI after pytest-xdist update Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b754690) 92.47% compared to head (b0de499) 92.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2469   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files         234      234           
  Lines       19814    19816    +2     
=======================================
+ Hits        18323    18325    +2     
  Misses       1491     1491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit c05b493 into main Nov 22, 2023
15 of 16 checks passed
@maxnoe maxnoe deleted the test_ci branch November 22, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants