Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cache=True to numba compilation #2477

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Add missing cache=True to numba compilation #2477

merged 1 commit into from
Dec 1, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 29, 2023

This shaved of a third of the import time (of course only of the second import) of ctapipe.io as reported by @GernotMaier here: #2476

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b175f69) 92.46% compared to head (61f4062) 92.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2477   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         234      234           
  Lines       19868    19868           
=======================================
  Hits        18370    18370           
  Misses       1498     1498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 29, 2023

Unfortunately, most of the remaining time is spent on importing tables.leaf, about a second on my machine, so that's out of our direct control.

@kosack kosack merged commit e861a64 into main Dec 1, 2023
14 checks passed
@kosack kosack deleted the missing_caches branch December 1, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants