Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load constant pointing in TableLoader #2481

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Dec 12, 2023

This adds the possibility to read the constant pointing stored per observation block introduced in #2438 in the TableLoader.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@e4402ad). Click here to learn what that means.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2481   +/-   ##
=======================================
  Coverage        ?   92.51%           
=======================================
  Files           ?      234           
  Lines           ?    19996           
  Branches        ?        0           
=======================================
  Hits            ?    18500           
  Misses          ?     1496           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kosack
kosack previously approved these changes Dec 12, 2023
Copy link
Contributor

@Tobychev Tobychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog should mention the new option of join_allow_empty, and codecov is probably right that there should be some test coverage of this new feature

@maxnoe maxnoe force-pushed the fixed_pointing_table_loader branch from 6ccfef6 to abb48c7 Compare January 4, 2024 11:58
@kosack kosack merged commit 17c1ae4 into main Jan 18, 2024
13 of 14 checks passed
@kosack kosack deleted the fixed_pointing_table_loader branch January 18, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants