-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on python 3.12 #2486
Test on python 3.12 #2486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
==========================================
- Coverage 92.53% 92.52% -0.01%
==========================================
Files 235 235
Lines 20024 20024
==========================================
- Hits 18529 18528 -1
- Misses 1495 1496 +1 ☔ View full report in Codecov by Sentry. |
wohoo 🎆 |
…test-xdist to test deps
Codecov project fails due to the changed python version for the coverage report now testing different lines in the compat code which happen to be slightly less lines. So I'd say this is ready to go. |
@@ -43,19 +43,23 @@ jobs: | |||
|
|||
- os: ubuntu-latest | |||
python-version: "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why phyton 3.10 only uses pip while 3.9, 3.11, and 3.12 also tries mamba?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason, we at some point in the past decided not to test on the full product matrix of [python versions] x [pip, mamba]
but to only test some combinations that cover all python versions and both installation methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To limit the number of parallel builds that run in the CI
@kosack this would be ready |
No description provided.