Move options from setup.cfg to pyproject.toml #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosack
reviewed
Feb 20, 2024
kosack
previously approved these changes
Feb 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
=======================================
Coverage 92.52% 92.53%
=======================================
Files 235 235
Lines 20024 20024
=======================================
+ Hits 18528 18530 +2
+ Misses 1496 1494 -2 ☔ View full report in Codecov by Sentry. |
maxnoe
force-pushed
the
pyproject_everything
branch
from
af596a0
to
ac56396
Compare
Tobychev
approved these changes
Feb 21, 2024
Tobychev
previously approved these changes
Feb 21, 2024
|
Sorry, needed to update the |
kosack
previously approved these changes
Feb 21, 2024
Tobychev
reviewed
Feb 22, 2024
| .eggs | ||
| max-line-length=90 | ||
| select = C,E,F,W,B,B950 | ||
| ignore = E501,W503,E203,W201,E712,E731 |
There was a problem hiding this comment.
Are these settings recreated outside the toml, or are they not relevant any more for some other reason?
There was a problem hiding this comment.
flake8 does not support being configured via pyproject.toml (the maintainer hates it for some reason) and since we intend to move to ruff (#2416) I didn't bother adding it to a .flake8 file
Tobychev
approved these changes
Feb 22, 2024
kosack
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using the standardized metadata and config for setuptools in pyproject.toml, gets rid of one config file.