Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/rename datawriter options (redux) #2520

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

kosack
Copy link
Contributor

@kosack kosack commented Mar 4, 2024

This replaces #1920 and is based on latest main branch

@maxnoe
Copy link
Member

maxnoe commented Mar 4, 2024

Changelog missing, otherwise looking good

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.53%. Comparing base (8f71cce) to head (d1a2ef5).

Files Patch % Lines
src/ctapipe/io/datawriter.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2520   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files         235      235           
  Lines       20063    20063           
=======================================
  Hits        18565    18565           
  Misses       1498     1498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosack kosack requested a review from maxnoe March 4, 2024 15:16
@maxnoe maxnoe merged commit 3952e5a into main Mar 5, 2024
14 of 16 checks passed
@maxnoe maxnoe deleted the refactor/rename_datawriter_options2 branch March 5, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants