-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sonar complaining about statements in notebooks #2527
Conversation
it also complains about lack of coverage and duplicated code in the examples, all of which are at least partially incorrect. |
Shall I just include the examples for everything? |
probably.. Those aren't really subject to code quality |
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 233 233
Lines 20056 20056
=======================================
Hits 18571 18571
Misses 1485 1485 ☔ View full report in Codecov by Sentry. |
@kosack with excluding the |
Sonarqube complained about statements that "have no effect" in the examples, but these are the output cell values for sphinx-gallery, so not actually a bug