Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sonar complaining about statements in notebooks #2527

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Mar 25, 2024

Sonarqube complained about statements that "have no effect" in the examples, but these are the output cell values for sphinx-gallery, so not actually a bug

@kosack
Copy link
Contributor

kosack commented Mar 25, 2024

it also complains about lack of coverage and duplicated code in the examples, all of which are at least partially incorrect.

@maxnoe
Copy link
Member Author

maxnoe commented Mar 25, 2024

Shall I just include the examples for everything?

@kosack
Copy link
Contributor

kosack commented Mar 25, 2024

Shall I just include the examples for everything?

probably.. Those aren't really subject to code quality

This comment has been minimized.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (597807a) to head (9112298).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         233      233           
  Lines       20056    20056           
=======================================
  Hits        18571    18571           
  Misses       1485     1485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (92.60% Estimated after merge)
  • Duplications No duplication information (0.70% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe
Copy link
Member Author

maxnoe commented Mar 25, 2024

@kosack with excluding the examples/**, codecov and sonarqube now agree on the coverage value

@maxnoe maxnoe requested review from Tobychev and kosack March 25, 2024 17:00
@kosack kosack merged commit 01f4a99 into main Mar 26, 2024
15 checks passed
@kosack kosack deleted the update_sonar2 branch March 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants