Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/custom exit codes in tools #2566

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Feature/custom exit codes in tools #2566

merged 9 commits into from
Jun 21, 2024

Commits on Jun 19, 2024

  1. Add SystemExit handling in Tool.run()

    @mexanick
    mexanick committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e02efee View commit details
    Browse the repository at this point in the history

  2. Fix logging laziness in tool.py

    @mexanick
    mexanick committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ac232fb View commit details
    Browse the repository at this point in the history

  3. Add test for SystemExit handling

    @mexanick
    mexanick committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    628e81f View commit details
    Browse the repository at this point in the history

  4. Fix ruff error

    @mexanick
    mexanick committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    2663085 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Add exit code to provenance 

    - Add "exit_code" field to provenance dictionary
- Update the possible provenance status values to
  ["success", "interrupted", "error", "partial_success"]
- Making the "partial_success" status default
  - It is overridden in finish_activity with a default "success"
    @mexanick
    mexanick committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8fef3fd View commit details
    Browse the repository at this point in the history

  2. Fix tests (do not re-intercept re-raised exceptions)

    @mexanick
    mexanick committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    636d451 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Change status "partial_success" to "error"

    @mexanick
    mexanick committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    bbe607c View commit details
    Browse the repository at this point in the history

  2. Change default status (at init) to "running"

    @mexanick
    mexanick committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    6925244 View commit details
    Browse the repository at this point in the history

  3. Add changes doc

    @mexanick
    mexanick committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    42ecb4c View commit details
    Browse the repository at this point in the history