Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update exception handling in tools #2594

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Update exception handling in tools #2594

merged 9 commits into from
Jul 31, 2024

Commits on Jul 19, 2024

  1. Update exception handling in tools 

    - Remove SystemExit handling in `Tool.run()`
- Add a possibility to register custom exceptions
  and handle them in `Tool.run()` with the preservation of the exit code.
    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6cfd59d View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7d8ead3 View commit details
    Browse the repository at this point in the history

  3. Add back SystemExit handling

    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    25fb2b9 View commit details
    Browse the repository at this point in the history

  4. Implement @maxnoe suggestions 

    - Simplify SystemExit handling
- Remove custom exception registration,
  but add a treatment of the custom exit codes when catching generic Exception
    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    464e5a0 View commit details
    Browse the repository at this point in the history

  5. Add re-raise in SystemExit treatment for testing purposes

    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d48fcb5 View commit details
    Browse the repository at this point in the history

  6. Simplify re-raise logic

    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9da3faf View commit details
    Browse the repository at this point in the history

  7. Remove distinction between expected and unexpected exceptions in the … 

    …log message
    @mexanick
    mexanick committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    00fe47a View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Update Tool documentation w.r.t Exceptions

    @mexanick
    mexanick committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    023eacb View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @mexanick
    mexanick committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    25a1400 View commit details
    Browse the repository at this point in the history