Changes to make this notebook work:Use EventSourceFactory. Corrected reading of camera geometry.

[moralejo]

No description provided.

[codecov]

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   68.14%   68.14%           
=======================================
  Files         196      196           
  Lines       10546    10546           
=======================================
  Hits         7187     7187           
  Misses       3359     3359

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a020ed5...e658ea1. Read the comment docs.

[kosack]

Is this really necessary? the event_source(filename) function is just a wrapper that creates an EventSourceFactory and it's product, so it seems this change is redundant, unless I'm misunderstanding something.

[moralejo]

Perhaps it can be done with event_source, and I misunderstood the source of the error related to the reading of camera geometry (the missing 'subarray'). In that case only the second change is needed. A.

…

On 23 April 2018 at 13:59, Karl Kosack ***@***.***> wrote: Is this really necessary? the event_source(filename) function is just a wrapper that creates an EventSourceFactory and it's product, so it seems this change is redundant, unless I'm misunderstanding something. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#716 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANghOvkGeNQyG3fWjIMKobh5JY9q1Fb3ks5trcIbgaJpZM4TexP_> .

-- Abelardo Moralejo Olaizola Institut de Física d'Altes Energies Tel : +34 931641662 Fax: +34 935811938 Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es

-- Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es <http://legal.ifae.es/>

[dneise]

This PR inspired another PR #724 which not only fixes this notebook but also 2 other notebooks.

I believe when #724 is merged this here can be closed.