-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing multiprocessing issue and minor bugfixes #108
Fixing multiprocessing issue and minor bugfixes #108
Conversation
-SPE_result read is a generator -typo -useless line to change events_per_slice to none but it's read only
a sorted image with pixels id
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 30.55% 30.72% +0.16%
==========================================
Files 58 60 +2
Lines 3701 3811 +110
==========================================
+ Hits 1131 1171 +40
- Misses 2570 2640 +70 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all these improvements!
This PR is fixing the issue89 and improves the SPE fit validity flag as asked in issue106
Concerning the
multiprocessing
issue, I changed the themultiprocessing
set up to create child processes from 'fork' to 'spawn', which is the default set up for mac and windows, and recommanded for linux.I also improved the validity flag for the SPE fit (thanks to @tibaldo).
I also fixed some bugs found by @tibaldo in the photo_statistic module.