-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container/component/tool for pedestal estimation #115
Conversation
Still not working
This is an example that works on stored waveforms without any filtering
…test" otherwise. (cta-observatory#112) Co-authored-by: Jean-Philippe Lenain <jlenain@in2p3.fr>
Co-authored-by: Jean-Philippe Lenain <jlenain@in2p3.fr>
* Activate the `pytest-xdist` addon for `pytest` in CI. * Fix typo --------- Co-authored-by: Jean-Philippe Lenain <jlenain@in2p3.fr>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
===========================================
+ Coverage 28.54% 39.43% +10.88%
===========================================
Files 62 65 +3
Lines 4102 4453 +351
===========================================
+ Hits 1171 1756 +585
+ Misses 2931 2697 -234 ☔ View full report in Codecov by Sentry. |
I think it is, maybe, because you pull from the main branch of the repo into your dev branch before pushing your commits into it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @tibaldo !
I tested your branch locally, and everything is running very smoothly.
To me, the PR is in an excellent shape and is ready to be merged.
This PR add a tool/component dedicated to estimate pedestals based on data that contain events of type
SKYPEDESTAL
. Pedestals are stored in a dedicated container following the nectarchain conventions (pixels_id
etc.).Several methods for filtering the data are available based on timestamps of the events, standard deviations of the waveforms and the charge distribution.
In order to reduce the memory load the tool is built in such a way that pedestals are estimated in slices with a number of events
events_per_slice
and then results combined at the end.PS: I'm not sure why in the file comparison I see the renaming master-> main which is already integrated in the upstream repository