Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find runs on GRID directly with the Dirac python API #90

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

guillaumegrolleron
Copy link
Contributor

I just changed the way to access the runs files stored on the GRID, before we had to access the ELog and the method was not robust.

Now we directly use the DIRAC API to search and find location of data with run number.

This feature makes possible to use tools and do not need to previously download runs files locally in $NECTARCAMDATA. nectarchain will check if the files are accessible locally, if not, it will automatically fetch them from the GRID and store them in ¤NECTARCAMDATA

guillaume.grolleron added 2 commits January 24, 2024 20:02
of logging which becomes in conflict with ctapipe
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (270c103) 30.55% compared to head (73cc74f) 30.75%.

Files Patch % Lines
src/nectarchain/data/management.py 20.00% 24 Missing ⚠️
src/nectarchain/utils/logger.py 50.00% 9 Missing ⚠️
src/nectarchain/utils/io.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   30.55%   30.75%   +0.19%     
==========================================
  Files          58       60       +2     
  Lines        3701     3762      +61     
==========================================
+ Hits         1131     1157      +26     
- Misses       2570     2605      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlenain jlenain linked an issue Jan 25, 2024 that may be closed by this pull request
@jlenain jlenain self-requested a review January 25, 2024 16:51
@jlenain jlenain added the enhancement New feature or request label Jan 25, 2024
Copy link
Collaborator

@jlenain jlenain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's brilliant, @guillaumegrolleron ! Thanks a lot !

@jlenain jlenain merged commit 6f11e5f into cta-observatory:master Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement use of dfind DIRAC API in DataManagement
2 participants