-
Notifications
You must be signed in to change notification settings - Fork 55
SourceLink not verifying files compiled by VS 2015? #102
Comments
Thanks for reporting this! Now we have two people reporting the same thing. @Thorium reported this last month, but haven't had time to look into it yet. |
C# Roslyn uses SHA1 and SHA-256 that are 20 bytes and 32 bytes in length. The MD5 is 16 bytes in length. That explains why the stream length is 92 bytes. The guid for SHA1 is |
@amazingant Can you try out build 281?
or
|
After wiping my working directory and setting |
Had some issues with it initially, due to the proxy page I wrote to get to the team's private GitHub repos. Now, I get back a nice list of files with their checksums, followed by |
Thanks! I'll probably release |
In the "not your issue but worth mentioning" category, trying to debug in VS with my new pdb file, it looks like SRCSRV doesn't like the URL I built for it. Organization, repository, commit SHA, etc. are all GET params after a question-mark, and is less than pleased with that. |
Correct. It doesn't support |
Would you think me insane if my workaround was a custom webserver running in fsi? |
Ha! No, I wrote a 60-line Node.js app as a proxy. :-) http://blog.ctaggart.com/2015/07/sourcelink-10-with-private-github.html Builds on Suave or ground up? |
Ground-up just using a Runs on port 8004, because this isn't the first time I gave up by writing a custom server; first time it's been running in fsi though. 😄 |
Trying to add a SourceLink build target to one of my projects at work, found that it wasn't verifying any of the source files. Followed the code in PdbChecksums.fs as best I can, and it looks like the source code is being filtered out because the "stream" length is 92 bytes instead of 88, as specified here.
Looked through the data and picked an arbitrary file out, the file's checksums (with the compiled line-endings), and the pdb data are:
I'm not intimately aware of the details of PDB generation, but I can safely say the PDB data ends with the SHA1, and SourceLink is looking for MD5's. :)
The text was updated successfully, but these errors were encountered: