Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extractAllTo() no longer preserves linux file permissions #530

Open
ocmstone opened this issue Aug 12, 2024 · 2 comments
Open

extractAllTo() no longer preserves linux file permissions #530

ocmstone opened this issue Aug 12, 2024 · 2 comments

Comments

@ocmstone
Copy link

ocmstone commented Aug 12, 2024 •
edited
Loading

In version 0.5.15, the following function call: zip.extractAllTo(unzipFileLocation, true, true)

Is supposed to keepOriginalPermission when the third argument is true. Up to version 0.5.14 this worked correctly, preserving Linux rwx permissions. But as of 0.5.15, it is as if there is a umask of 0o117 when unpacking. It also adds write permission for group.

A file in the zip archive was saved with these permissions:
-rwxr-x--- 1 user staff 9744 Aug 12 2024 opscompass.sh*

But unzipped as:
-rw-rw---- 1 user staff 9744 Aug 12 2024 opscompass.sh*

VERIFIED: 0.5.14 still works correctly
@NickAllmakerOpsCompass
Copy link
Contributor

I'm not 100% sure but it looks like the issue was introduced by the change to number parsing in #518. Specifically, I think that when fileAttr switched from just doing bitwise arithmetic to the uint16 helper, that caused it to start turning fileAttr into 0.

Merged
@zabil zabil mentioned this issue Aug 14, 2024
Merged
chadlwilson added a commit to chadlwilson/gauge that referenced this issue Aug 14, 2024
@chadlwilson
Fix cli npm package installs on Linux/MacOS
f81090a 
Locks package at 0.5.14 since 0.5.15 seemed to introduce
the problem at cthackers/adm-zip#530

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
@chadlwilson chadlwilson mentioned this issue Aug 14, 2024
Merged
chadlwilson added a commit to chadlwilson/gauge that referenced this issue Aug 14, 2024
@chadlwilson
Fix cli npm package installs on Linux/MacOS
3ced4ce 
Locks package at 0.5.14 since 0.5.15 seemed to introduce
the problem at cthackers/adm-zip#530

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
zabil pushed a commit to getgauge/gauge that referenced this issue Aug 14, 2024
@chadlwilson
Fix cli npm package installs on Linux/MacOS (#2589)
afc97cb 
* Fix golint warnings

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>

* Fix cli npm package installs on Linux/MacOS

Locks package at 0.5.14 since 0.5.15 seemed to introduce
the problem at cthackers/adm-zip#530

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>

---------

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
@chadlwilson
Copy link

This was fixed by #531 - @cthackers would you be able to cut a 0.5.16 release to fix this regression? 🙏

will-v-pi added a commit to raspberrypi/pico-vscode that referenced this issue Aug 23, 2024
@will-v-pi
Downgrade adm-zip to 0.5.14
bd5c186 
0.5.15 doesn't respect linux file permissions (cthackers/adm-zip#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chadlwilson @ocmstone @NickAllmakerOpsCompass