Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Zip64 files and forEach method #301

Merged
merged 2 commits into from
Feb 6, 2020
Merged

[WIP] Zip64 files and forEach method #301

merged 2 commits into from
Feb 6, 2020

Conversation

pierre-lehnen-rc
Copy link
Contributor

  • Adds support to files with more than 65535 entries
  • Adds a method to iterate over entries without loading all of them to memory at the same time.

@pierre-lehnen-rc pierre-lehnen-rc changed the title [NEW] Zip64 files and forEach method [WIP] Zip64 files and forEach method Jan 31, 2020
@cthackers cthackers merged commit 8176b02 into cthackers:master Feb 6, 2020
@pierre-lehnen-rc
Copy link
Contributor Author

Most of the code is using var's only here we are using ECMA6. Is there a reason on why?

I messed up :/
For the first commit I was careful to keep the code in the same style of the repository, but I forgot about it on the second commit.

@hkbarton hkbarton mentioned this pull request Jul 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-lehnen-rc @puppeteer701vungle @cthackers