Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotate additional subdirectories #286

Closed
djsegal opened this issue Nov 11, 2015 · 6 comments
Closed

annotate additional subdirectories #286

djsegal opened this issue Nov 11, 2015 · 6 comments
Assignees
@ctran
Labels
feature
Milestone
v2.7.0

Comments

@djsegal
Copy link
Contributor

djsegal commented Nov 11, 2015

a scaffold generates files in the following rspec subdirectories:

  • spec/models
  • spec/controllers
  • spec/requests
  • spec/routing

currently, only spec/models is annotated. is there a way to annotate the other three?
@ctran
Copy link
Owner

ctran commented Nov 11, 2015

A PR is welcome! What version of rails does this?

@ctran ctran added the feature label Nov 11, 2015
@djsegal djsegal mentioned this issue Nov 11, 2015
Merged
@djsegal
Copy link
Contributor Author

djsegal commented Nov 11, 2015

I'm testing it now. I'm working with a Rails 5 API

@djsegal
Copy link
Contributor Author

djsegal commented Nov 15, 2015

I just finished the PR and tested it with test_unit and rspec: #287

@djsegal
Copy link
Contributor Author

djsegal commented Nov 16, 2015

@ctran is there anything more I can do to help?

@ctran
Copy link
Owner

ctran commented Nov 17, 2015

Sorry, I will take a look tomorrow.

On Mon, Nov 16, 2015 at 3:14 PM djsegal notifications@github.com wrote:

@ctran https://github.com/ctran is there anything more I can do to help?

—
Reply to this email directly or view it on GitHub
#286 (comment)
.

ctran added a commit that referenced this issue Nov 18, 2015
@ctran
Merge pull request #287 from djsegal/develop
af4606a 
Annotate non-model test files: #286
@ctran ctran added this to the v2.6.11 milestone Nov 18, 2015
@ctran ctran self-assigned this Nov 18, 2015
@ctran
Copy link
Owner

ctran commented Nov 18, 2015

This is now merged into "develop". It will be part of the next release.

@ctran ctran closed this as completed Nov 18, 2015
@ctran ctran modified the milestones: v2.6.11, v2.7.0 Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctran ctran

Labels
feature
Projects
None yet
Milestone
v2.7.0
Development

No branches or pull requests
2 participants
@ctran @djsegal