Add annotation hooks for db-specific migration tasks #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-mannino
force-pushed
the
support-multi-db
branch
from
ed940b0 to
aed041d
Compare
Vasfed
reviewed
Dec 5, 2019
paul-mannino
force-pushed
the
support-multi-db
branch
from
aed041d to
37f8b16
Compare
|
Hi @paul-mannino thanks for this and I apologize for not reviewing this earlier. Since this PR was up I've added an integration test in |
Rails 6 adds a new set of migration tasks for multi-database apps. This change makes the annotate_models_migrate hooks aware of them.
paul-mannino
force-pushed
the
support-multi-db
branch
from
37f8b16 to
5059f91
Compare
@drwl That makes it a bit nicer to test. Lmk if there's anything you want me to change after the latest refactor |
drwl
approved these changes
May 17, 2020
| @@ -19,91 +82,31 @@ | |||
| end | |||
| end | |||
|
|
|||
| around(:each) do |example| | |||
ocarta-l
pushed a commit
to ocarta-l/annotate_models
that referenced
this pull request
Jun 18, 2021
Rails 6 adds a new set of migration tasks for multi-database apps. This change makes the annotate_models_migrate hooks aware of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6 adds a new set of migration tasks for multi-database apps. This change makes the annotate_models_migrate hooks aware of them.
This change was a little awkward to test, but I'm happy to change my approach/use a dummy app for more robust integration tests if desired.