Add upgrade instructions to README #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gingerlime if you want to review |
gingerlime
reviewed
Nov 11, 2019
README.rdoc
Outdated
| {change was added in #647}[link:https://github.com/ctran/annotate_models/pull/647] to change this. You {can read more here}[https://github.com/ctran/annotate_models/issues/663]. | ||
|
|
||
| There are a few ways of fixing this. | ||
| 1. If using CLI explicitly pass in models flag using +--models+ |
There was a problem hiding this comment.
perhaps the easiest way is to run rails g annotate:install ? :)
gingerlime
reviewed
Nov 11, 2019
README.rdoc
Outdated
| @@ -50,6 +50,18 @@ It also annotates geometrical columns, geom type and srid, when using | |||
| Also, if you pass the -r option, it'll annotate routes.rb with the output of | |||
| <code>rake routes</code>. | |||
|
|
|||
| == Upgrading to 3.X and annotate models not working? | |||
| In versions 2.7.X the annotate gem defaulted to annotating models if no arguments were passed in. The annotate gem by default would not allow for routes and models to be annotated together. A | |||
| {change was added in #647}[link:https://github.com/ctran/annotate_models/pull/647] to change this. You {can read more here}[https://github.com/ctran/annotate_models/issues/663]. | |||
|
Thanks for pinging me. Just made a couple of small suggestions :) |
|
@gingerlime added some changes, wanna take another look? |
gingerlime
reviewed
Nov 12, 2019
|
just spotted one small thing (potentially). Otherwise 👍 Sorry if this is a dumb question, but couldn't you detect if |
|
@gingerlime sorry for the way delayed response, but yes can make that change. In the mean time will add this so folks can see this in the README. |
peterfication
pushed a commit
to store2be/annotate_models
that referenced
this pull request
Jan 20, 2020
Updates the readme to include a note about upgrading the gem to version 3 and that it can default to doing nothing.
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
Updates the readme to include a note about upgrading the gem to version 3 and that it can default to doing nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.