Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RSpec for AnnotateModels (4) - AnnotateModels.get_schema_info (without custom options) #735

Merged

Conversation

nard-tech
Copy link
Collaborator

I refactored test cases of AnnotateModels without custom options.

I will refactor the test case added in #602 in another PR.

@nard-tech nard-tech force-pushed the feature/refactor_annotate_models/rspec/clean_v4 branch from aa12855 to 724a83f Compare January 20, 2020 20:48
@drwl
Copy link
Collaborator

drwl commented Jan 26, 2020

@nard-tech what does changing the position of test cases do?

@drwl drwl merged commit f3db77f into ctran:develop Jan 26, 2020
@nard-tech nard-tech deleted the feature/refactor_annotate_models/rspec/clean_v4 branch January 26, 2020 22:01
@nard-tech
Copy link
Collaborator Author

@drwl After #741, I'd like to separate .get_schema_info to another namespace because AnnotateModels is too fat to maintain.
At that time I will change the position of test cases.

vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
…o (without custom options) (ctran#735)

I refactored test cases of AnnotateModels without custom options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants