Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CHANGELOG.md to add link to each PR #751

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

dkmrkm1
Copy link
Contributor

@dkmrkm1 dkmrkm1 commented Feb 3, 2020

Summary

  • Fixed CHANGELOG.md to add link to each PR

We're always grateful to use.
Thanks.

Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for doing this! Added an ask.

CHANGELOG.md Outdated
- Bump nokogiri from 1.6.6.2 to 1.10.4 in /spec/integration/rails_4.2.0 (#655)
- Default annotate models to true in config generated by `rails g annotate:install` (#671)
- Bump loofah from 2.3.0 to 2.3.1 in /spec/integration/rails_4.2.0 (#681)
- Use a less error-prone way of specifying gem files (https://github.com/ctran/annotate_models/pull/662)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have links in the format #662?

[#xxx](https://github.com/ctran/annotate_models/pull/xxx)

This would make the changelog links shorter but also be able to use the link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for seeing.
Fixed.

@drwl drwl added the reviewed label Feb 3, 2020
Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for change and first contribution to project 😎

@drwl drwl merged commit 5ee617e into ctran:develop Feb 4, 2020
@dkmrkm1 dkmrkm1 deleted the fix_changelog_to_add_link_to_pr branch February 4, 2020 03:54
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
* Fixed CHANGELOG.md to add link to each PR

* Fixed link to markdown format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants