Fix: use klass.table_name instead of guessing from associated models #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In a middle of a refactoring task, we came across a issue with globalize + annotate. Annotate is adding a none-existant field to the model:
The issue come when you overide
table_name
. For exemple, if we have a modelCountry
located atmodels/country.rb
and we decide to move the file in a folder without changing the table_name, we will have:models/folder/country.rb
With the orginal code, we have:
Using table_name is a safer way to do it, in my opinion