Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make with_comment_column work with Annotate.set_defaults #999

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Make with_comment_column work with Annotate.set_defaults #999

merged 10 commits into from
Nov 30, 2023

Conversation

Adeynack
Copy link
Contributor

Fixes #990

@Adeynack Adeynack mentioned this pull request Nov 15, 2023
Closed
@Adeynack Adeynack marked this pull request as ready for review November 15, 2023 00:06
@sureshc
Copy link

sureshc commented Nov 15, 2023

Thank you! I'm not familiar with this codebase. Are there any tests that need to be updated to validate this change?

@Adeynack
Copy link
Contributor Author

@sureshc : The only test I found that seems to concern .set_defaults are strangely specific to ONE configuration key, so I decided to not touch it. @ctran can maybe point me at where it would be decent to test this thing. I am also very uncomfortable in submitting modifications without any kind of automated testing proving its worth.

@ctran
Copy link
Owner

ctran commented Nov 15, 2023

@sureshc : The only test I found that seems to concern .set_defaults are strangely specific to ONE configuration key, so I decided to not touch it. @ctran can maybe point me at where it would be decent to test this thing. I am also very uncomfortable in submitting modifications without any kind of automated testing proving its worth.

Maybe add a new test in https://github.com/ctran/annotate_models/blob/master/spec/lib/tasks/annotate_models_migrate_spec.rb?

@Adeynack
Copy link
Contributor Author

@ctran : I added a brand new spec file for it, since I judged it was a separate concern than what's in annotate_models_migrate_spec. But thanks a lot for this hint, it pushed me directly in the right direction! 🤩

@Adeynack
Copy link
Contributor Author

@sureshc @ctran : Code is complete & tests were written. Please review 😺

ctran
ctran approved these changes Nov 30, 2023
View reviewed changes
Copy link
Owner

@ctran ctran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

spec/lib/tasks/annotate_models_spec.rb Show resolved Hide resolved
@ctran ctran self-assigned this Nov 30, 2023
@ctran ctran added this to the v3.2.1 milestone Nov 30, 2023
@ctran ctran merged commit 5d01c41 into ctran:develop Nov 30, 2023
3 checks passed
@Adeynack Adeynack deleted the feature/make_with_comment_column_work_with_annotate_set_defaults branch November 30, 2023 10:34
@omkarmoghe omkarmoghe mentioned this pull request Jan 6, 2024
Open
@Adeynack Adeynack mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctran ctran ctran approved these changes

Assignees

@ctran ctran

@Adeynack Adeynack

Labels
None yet
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.

Make with_comment_column work with Annotate.set_defaults
3 participants
@Adeynack @sureshc @ctran