Property types, part II #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @cuba-platform/react-ui, @cuba-platform/rest related to #36
affects: @cuba-platform/react-ui, @cuba-platform/front-generator related to #36
affects: @cuba-platform/react-ui, @cuba-platform/front-generator - Values of many-to-many Associations are now displayed in DataTable - Associations are now shown in the same manner as in the Generic UI: - One-to-many Associations are not shown anymore at the owning side - One-to-one Associations are not shown anymore at the inverse side related to #36
affects: @cuba-platform/front-generator related to #36
affects: @cuba-platform/react-ui related to #36
vadimbasko
reviewed
Feb 7, 2020
vadimbasko
reviewed
Feb 7, 2020
packages/front-generator/src/generators/react-typescript/common/entity.ts
Outdated
Show resolved
Hide resolved
vadimbasko
reviewed
Feb 7, 2020
vadimbasko
reviewed
Feb 7, 2020
|
Strongly recommend to write puppeteer tests for different PropertyTypes. All environment to easy test creation (ci run, login, samples) implemented in 'New cuba rest permission' issue #97 (hope it will be merged soon). Or I can separate it to different pull request, if you need it earlier. |
vadimbasko
approved these changes
Feb 7, 2020
affects: @cuba-platform/front-generator
affects: @cuba-platform/react-ui
web-devel
approved these changes
Feb 7, 2020
Agreed, I'll add puppeteer tests once #97 is merged. Created #105 to track that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36
InputNumberfor numeric fields:uuid.- One-to-many Associations are not shown anymore at the owning side
- One-to-one Associations are not shown anymore at the inverse side
byteArray(similar to Generic UI)