Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CC-1043] Add ability to dismiss notifications in List #207

Merged
merged 8 commits into from
Sep 13, 2022
Merged

[CC-1043] Add ability to dismiss notifications in List #207

merged 8 commits into from
Sep 13, 2022

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Sep 7, 2022 •
edited
Loading

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: CC-1043

Other information

Extracted <NotificationsList /> into the separate folder

@MrFlashAccount MrFlashAccount self-assigned this Sep 7, 2022
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: fb29978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022 •
edited
Loading

🏗 Docs are successfully deployed!

👀 Preview: https://631a19117cb3cd0070730a2f--cube-uikit-storybook.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022 •
edited
Loading

📦 NPM canary release

Deployed canary version 0.0.0-canary-50e15f8.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022 •
edited
Loading

🏋️ Size limit report

Name Size Passed?
All 154.3 KB (-0.03% 🔽👏) Yes 🎉
Tree shaking (just a Button) 32.14 KB (+0.13% 🔺) Yes 🎉

Click here if you want to find out what is changed in this build

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022 •
edited
Loading

🧪 Storybook is successfully deployed!

@tenphi tenphi merged commit fa16cd6 into main Sep 13, 2022
@tenphi tenphi deleted the bugfix/CC-1043 branch September 13, 2022 15:48
@github-actions github-actions bot mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenphi tenphi tenphi approved these changes

Assignees

@MrFlashAccount MrFlashAccount

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrFlashAccount @tenphi