Skip to content

Commit

Permalink
fix(@cubejs-backend/elasticsearch-driver): respect ungrouped parameter (
Browse files Browse the repository at this point in the history
#684) Thanks to @gauravlanjekar!

Co-authored-by: gaurav lanjekar <gaurav@leanspace.io>
  • Loading branch information
gauravlanjekar and glanjekar authored Jun 3, 2020
1 parent 28dc4de commit 27d0d49
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ class AWSElasticSearchQuery extends BaseQuery {
}

groupByClause() {
if (this.ungrouped) {
return '';
}
const dimensionsForSelect = this.dimensionsForSelect();
const dimensionColumns = R.flatten(dimensionsForSelect.map(s => s.selectColumns() && s.dimensionSql()))
.filter(s => !!s);
Expand Down

0 comments on commit 27d0d49

Please sign in to comment.