fix(cli): jdbc-driver fail hides db type not supported errors

cube-js · Jun 11, 2019 · 6f7c675 · 6f7c675
1 parent e8a59c2
commit 6f7c675
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/packages/cubejs-cli/cubejsCli.js b/packages/cubejs-cli/cubejsCli.js
@@ -92,6 +92,9 @@ const createApp = async (projectName, options) => {
   logStage('Installing DB driver dependencies');
   const CubejsServer = await requireFromPackage('@cubejs-backend/server');
   let driverDependencies = CubejsServer.driverDependencies(options.dbType);
+  if (!driverDependencies) {
+    await displayError(`Unsupported db type: ${chalk.green(options.dbType)}`, createAppOptions);
+  }
   driverDependencies = Array.isArray(driverDependencies) ? driverDependencies : [driverDependencies];
   if (driverDependencies[0] === '@cubejs-backend/jdbc-driver') {
     driverDependencies.push('node-java-maven');
@@ -151,9 +154,9 @@ const createApp = async (projectName, options) => {
   console.log();
   console.log(`📊 Next step: run dev server`);
   console.log();
-  console.log(`     1. $ cd ${projectName}`);
-  console.log(`     2. Edit .env file to set your DB credentials`);
-  console.log(`     3. $ npm run dev`);
+  console.log(`     $ cd ${projectName}`);
+  console.log(`     Edit .env file to set your DB credentials`);
+  console.log(`     $ npm run dev`);
   console.log();
 };
 

diff --git a/packages/cubejs-server-core/core/index.js b/packages/cubejs-server-core/core/index.js
@@ -17,7 +17,8 @@ const DriverDependencies = {
   mongobi: '@cubejs-backend/mongobi-driver',
   bigquery: '@cubejs-backend/bigquery-driver',
   redshift: '@cubejs-backend/postgres-driver',
-  clickhouse: '@cubejs-backend/clickhouse-driver'
+  clickhouse: '@cubejs-backend/clickhouse-driver',
+  hive: '@cubejs-backend/jdbc-driver'
 };
 
 const checkEnvForPlaceholders = () => {
@@ -260,7 +261,10 @@ class CubejsServerCore {
   }
 
   static driverDependencies(dbType) {
-    return DriverDependencies[dbType] || DriverDependencies.jdbc;
+    if (!DriverDependencies[dbType]) {
+      throw new Error(`Unsupported db type: ${dbType}`);
+    }
+    return DriverDependencies[dbType];
   }
 }