feat(cubestore): Implement CACHE REMOVE

cube-js · Sep 14, 2022 · abade08 · abade08
1 parent 16e903b
commit abade08
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/rust/cubestore/cubestore/src/metastore/mod.rs b/rust/cubestore/cubestore/src/metastore/mod.rs
@@ -3722,8 +3722,19 @@ impl MetaStore for RocksMetaStore {
     }
 
     async fn cache_delete(&self, key: String) -> Result<(), CubeError> {
-        self.write_operation(move |db_ref, batch_pipe| Ok(()))
-            .await?;
+        self.write_operation(move |db_ref, batch_pipe| {
+            let cache_schema = CacheItemRocksTable::new(db_ref.clone());
+            let index_key = CacheItemIndexKey::ByKey(key);
+            let row_opt =
+                cache_schema.get_single_opt_row_by_index(&index_key, &CacheItemRocksIndex::Key)?;
+
+            if let Some(row) = row_opt {
+                cache_schema.delete(row.id, batch_pipe)?;
+            }
+
+            Ok(())
+        })
+        .await?;
 
         Ok(())
     }

diff --git a/rust/cubestore/cubestore/src/sql/mod.rs b/rust/cubestore/cubestore/src/sql/mod.rs
@@ -1086,7 +1086,7 @@ impl SqlService for SqlServiceImpl {
                 }
             }
             CubeStoreStatement::CacheRemove { key } => {
-                let key = key.value;
+                self.db.cache_delete(key.value).await?;
 
                 Ok(Arc::new(DataFrame::new(vec![], vec![])))
             }