Skip to content

Commit

Permalink
Propagate server core version for correct error handling
Browse files Browse the repository at this point in the history
  • Loading branch information
paveltiunov committed Apr 24, 2019
1 parent b489090 commit b2dc953
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion packages/cubejs-playground/src/App.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ class App extends Component {
const res = await fetch('/playground/context');
const result = await res.json();
if (window.analytics) {
window.analytics.identify(result.anonymousId);
window.analytics.identify(result.anonymousId, {
coreServerVersion: result.coreServerVersion
});
}
}

Expand Down
3 changes: 2 additions & 1 deletion packages/cubejs-server-core/core/DevServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ class DevServer {
res.json({
cubejsToken: jwt.sign({}, this.cubejsServer.apiSecret, { expiresIn: '1d' }),
apiUrl: process.env.CUBEJS_API_URL,
anonymousId: this.cubejsServer.anonymousId
anonymousId: this.cubejsServer.anonymousId,
coreServerVersion: this.cubejsServer.coreServerVersion
});
}));

Expand Down

0 comments on commit b2dc953

Please sign in to comment.