fix: allow renewQuery in dev mode with warning (#868) Thanks to @jcw-!

* fix: allow renewQuery in dev mode with warning * Empty commit to trigger a CI rerun * Fix specs
cube-js · Jul 28, 2020 · dbdbb5f · dbdbb5f
1 parent 0778afd
commit dbdbb5f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/cubejs-playground/src/components/CachePane.js b/packages/cubejs-playground/src/components/CachePane.js
@@ -76,6 +76,7 @@ const CachePane = ({ query, cubejsApi }) => (
                   title: 'Refresh Key Value',
                   key: 'value',
                   render: (text, record) => rs && rs.loadResponse.usedPreAggregations
+                    && rs.loadResponse.usedPreAggregations[record.tableName].refreshKeyValues
                     && rs.loadResponse.usedPreAggregations[record.tableName].refreshKeyValues.map(k => (
                       <PrismCode
                         key={JSON.stringify(k)}

diff --git a/packages/cubejs-query-orchestrator/orchestrator/PreAggregations.js b/packages/cubejs-query-orchestrator/orchestrator/PreAggregations.js
@@ -182,7 +182,16 @@ class PreAggregationLoader {
     this.structureVersionPersistTime = preAggregations.structureVersionPersistTime;
     this.externalRefresh = options.externalRefresh;
     if (this.externalRefresh && this.waitForRenew) {
-      throw new Error("Invalid configuration - when externalRefresh is true, it will not perform a renew, therefore you cannot wait for it using waitForRenew.");
+      const message = 'Invalid configuration - when externalRefresh is true, it will not perform a renew, therefore you cannot wait for it using waitForRenew.';
+      if (['production', 'test'].includes(process.env.NODE_ENV)) {
+        throw new Error(message);
+      } else {
+        this.logger('Invalid Configuration', {
+          requestId: this.requestId,
+          warning: message,
+        });
+        this.waitForRenew = false;
+      }
     }
   }