-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SqliteDriver.js): Fixed table schema parsing #289
Conversation
@philippefutureboy Hey Philippe! Thanks for contributing this! I believe square brackets are optional. Should we support both cases: with and without square brackets? |
@paveltiunov Hey Pavel :) Let me know :) |
@philippefutureboy Yeah. Please do. |
Fix now supports all escape symbols and absence of escape symbol. + Refactored the `tables.map.reduce` to `tables.reduce` instead.
@paveltiunov Done! To test, simply use the test data below:
And run against the code at lines 49-65 :) |
@philippefutureboy Looks great! Thanks for contributing this! Really appreciate it! |
Always a pleasure to contribute :) |
1- .match on line 52 returned null => fixed by removing the EOL character
2- The describe table returns the name of the field between square brackets => fixed by removing the square brackets (see https://www.sqlitetutorial.net/sqlite-tutorial/sqlite-describe-table/)
Check List
Issue Reference this PR resolves
(self contained, did not create an issue beforehand)