Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-core): nullish measure values [v0.29] #3664

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

vasilev-alex
Copy link
Member

@vasilev-alex vasilev-alex commented Nov 15, 2021

All undefined/null measure values will now be converted to 0

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #3664 (0016438) into master (3af3c84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3664   +/-   ##
=======================================
  Coverage   59.38%   59.38%           
=======================================
  Files         125      125           
  Lines       10095    10095           
  Branches     2294     2294           
=======================================
  Hits         5995     5995           
  Misses       3814     3814           
  Partials      286      286           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af3c84...0016438. Read the comment docs.

@vasilev-alex vasilev-alex changed the title fix(client-core): nullish measure values fix(client-core): nullish measure values [0.29 release] Nov 29, 2021
@vasilev-alex vasilev-alex changed the title fix(client-core): nullish measure values [0.29 release] fix(client-core): nullish measure values [v0.29] Nov 29, 2021
@vasilev-alex vasilev-alex merged commit f28f803 into master Dec 14, 2021
@vasilev-alex vasilev-alex deleted the nullish-measures branch December 14, 2021 13:32
@vprus
Copy link

vprus commented Apr 5, 2022

@vasilev-alex : Alex, could I ask what was the motivation for this breaking change? In UI, it's important to distinguish between "no data yet" and "all our business metrics are 0", and this change forces the metrics to be '0'. After that, UI has no way to distinguish between those semantically different situations. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants