Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend meta response with aggregation type #394

Merged
merged 1 commit into from
Feb 17, 2020
Merged

feat: Extend meta response with aggregation type #394

merged 1 commit into from
Feb 17, 2020

Conversation

pyrooka
Copy link
Contributor

@pyrooka pyrooka commented Feb 17, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#368

@paveltiunov
Copy link
Member

Hey @pyrooka ! Looks great! Thanks for contributing it!

@paveltiunov paveltiunov merged commit 06eed0b into cube-js:master Feb 17, 2020
@ifokeev
Copy link

ifokeev commented Feb 17, 2020

@paveltiunov don't want to open new issue: tell, please, where is aliasName? why you removed it from the meta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants