Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast double to decimal for postgres #421

Merged

Conversation

sandeepravi
Copy link
Contributor

@sandeepravi sandeepravi commented Feb 20, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

While pre-aggregating data from Aws Athena to postgres, there was an issue because Athena supports "double" whereas postgres does not.

Added a mapping to convert "double" fields to "decimal"

@paveltiunov
Copy link
Member

@sandeepravi Hey Sandeep! Thanks for contributing this one! Do you think it should map to decimal or to double precision?

@sandeepravi
Copy link
Contributor Author

yeah, I thought about this but I thought decimal should cover all cases as there's no limit on the storage.

But yeah, since postgres supports "double precision", it can be double precision as well.

@paveltiunov
Copy link
Member

@sandeepravi Yep. Agree! Let's stick with decimal for now and see how it goes. Thanks for contributing this one!

@paveltiunov paveltiunov merged commit a19410a into cube-js:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants