Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including format and type in tableColumns #587

Merged
merged 3 commits into from
Apr 14, 2020

Conversation

danpanaite
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves
#585

@codecov-io
Copy link

codecov-io commented Apr 13, 2020

Codecov Report

Merging #587 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files          40       40           
  Lines        3283     3283           
=======================================
  Hits         2652     2652           
  Misses        631      631           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2083d46...69f5a1c. Read the comment docs.

@paveltiunov
Copy link
Member

@danpanaite Hey Dan! Looks great! Thanks for contributing this one! @cubejs-client-core.md is autogenerated however. You should edit corresponding JSDoc instead.

@danpanaite
Copy link
Contributor Author

@paveltiunov Ah thanks missed that! I've updated the corresponding JSDoc, but I'm not exactly sure how to run the doc generation. I've kept the changes in the md file, but I can revert and auto-generate it.

@paveltiunov
Copy link
Member

@danpanaite Looks great! We actually just need to remove this file because it's contents doesn't affect actual docs state.

@paveltiunov paveltiunov merged commit 3f7d74f into cube-js:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants