Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Some improvements for Cube Store queue #6022

Merged
merged 2 commits into from
Jan 18, 2023
Merged

chore: Some improvements for Cube Store queue #6022

merged 2 commits into from
Jan 18, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Jan 17, 2023 •
edited
Loading

Hello!

refs #5042

Thanks

@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Base: 41.31% // Head: 41.31% // No change to project coverage 👍

Coverage data is based on head (a25898b) compared to base (2d39fe4).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6022   +/-   ##
=======================================
  Coverage   41.31%   41.31%           
=======================================
  Files         151      151           
  Lines       20037    20037           
  Branches     5214     5214           
=======================================
  Hits         8279     8279           
  Misses      10919    10919           
  Partials      839      839
Flag Coverage Δ
cube-backend 41.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr marked this pull request as ready for review January 18, 2023 14:20
@ovr ovr requested review from a team as code owners January 18, 2023 14:20
waralexrom
waralexrom approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@waralexrom waralexrom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ovr ovr merged commit 0f4a431 into master Jan 18, 2023
@ovr ovr deleted the cubestore-queue-size branch January 18, 2023 14:50
@rpaik rpaik added Epic Major changes and features from the core team. cube store Issues relating to Cube Store Roadmap: 2022 Q4 Cube roadmap for Q4 of 2022 labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waralexrom waralexrom waralexrom approved these changes

Assignees
No one assigned
Labels
cube store Issues relating to Cube Store Epic Major changes and features from the core team. Roadmap: 2022 Q4 Cube roadmap for Q4 of 2022
Projects
No open projects
Roadmap FY2023 Q4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ovr @waralexrom @rpaik