Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-use external connection for CubeStore in queue #6028

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Jan 18, 2023

Hello!

refs #5042

Thanks

@ovr ovr marked this pull request as ready for review January 18, 2023 15:34
@ovr ovr requested a review from a team as a code owner January 18, 2023 15:34
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 41.31% // Head: 41.31% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6367104) compared to base (0f4a431).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6028      +/-   ##
==========================================
- Coverage   41.31%   41.31%   -0.01%     
==========================================
  Files         151      151              
  Lines       20037    20039       +2     
  Branches     5214     5214              
==========================================
  Hits         8279     8279              
- Misses      10919    10920       +1     
- Partials      839      840       +1     
Flag Coverage Δ
cube-backend 41.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.63% <ø> (ø)
...-query-orchestrator/src/orchestrator/QueryCache.ts 66.33% <0.00%> (-0.22%) ⬇️
...orchestrator/src/orchestrator/QueryOrchestrator.ts 55.00% <ø> (ø)
...-query-orchestrator/src/orchestrator/QueryQueue.js 62.53% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr force-pushed the query-orchestrator-cubestore-fix branch from bfc777e to 6367104 Compare January 18, 2023 15:49
@ovr ovr merged commit ff724f7 into master Jan 18, 2023
@ovr ovr deleted the query-orchestrator-cubestore-fix branch January 18, 2023 16:27
@rpaik rpaik added Epic Major changes and features from the core team. cube store Issues relating to Cube Store Roadmap: 2022 Q4 Cube roadmap for Q4 of 2022 labels Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cube store Issues relating to Cube Store Epic Major changes and features from the core team. Roadmap: 2022 Q4 Cube roadmap for Q4 of 2022
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants