-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cubestore): Correct orphaned detection + optimizations #6051
Conversation
.into_iter() | ||
.filter(|item| item.get_row().status == status_filter) | ||
.collect() | ||
let index_key = QueueItemIndexKey::ByPrefixAndStatus(prefix, status_filter); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to improve Performance: Usage of index
|item| { | ||
let mut new = item.clone(); | ||
new.status = QueueItemStatus::Active; | ||
let mut new = id_row.get_row().clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to improve Performance: update_with_fn
do an additional lookup.
let mut new = id_row.get_row().clone(); | ||
new.update_heartbeat(); | ||
|
||
queue_schema.update(id_row.id, new, id_row.get_row(), batch_pipe)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to improve Performance: update_with_fn
do an additional lookup.
e3f3e62
to
a29a9dd
Compare
Hello!
refs #5042
Thanks