Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubestore-driver): Cancel handling #6087

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Conversation

ovr
Copy link
Member

@ovr ovr commented Jan 30, 2023

Hello!

refs #5042

Thanks

@ovr ovr requested review from a team as code owners January 30, 2023 12:41
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 41.60% // Head: 41.60% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c630529) compared to base (9732af6).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6087   +/-   ##
=======================================
  Coverage   41.60%   41.60%           
=======================================
  Files         152      152           
  Lines       20091    20092    +1     
  Branches     5242     5238    -4     
=======================================
+ Hits         8358     8360    +2     
+ Misses      11423    11422    -1     
  Partials      310      310           
Flag Coverage Δ
cube-backend 41.60% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-orchestrator/src/orchestrator/RedisQueueDriver.js 2.58% <0.00%> (ø)
...-query-orchestrator/src/orchestrator/QueryQueue.js 72.10% <66.66%> (+0.38%) ⬆️
...y-orchestrator/src/orchestrator/BaseQueueDriver.ts 100.00% <100.00%> (ø)
...-orchestrator/src/orchestrator/LocalQueueDriver.js 89.07% <100.00%> (ø)
...-query-orchestrator/src/orchestrator/QueryCache.ts 66.33% <100.00%> (ø)
...ubejs-query-orchestrator/src/orchestrator/utils.ts 86.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr force-pushed the cubestore-queue-cancel-fix branch 5 times, most recently from d7ec9a5 to 382e2d6 Compare January 30, 2023 14:30
@ovr ovr force-pushed the cubestore-queue-cancel-fix branch from 382e2d6 to 0e1f2ad Compare January 30, 2023 14:49
@ovr ovr force-pushed the cubestore-queue-cancel-fix branch from 9b06362 to 31ca047 Compare January 30, 2023 16:16
@ovr ovr merged commit 03089ce into master Jan 30, 2023
@ovr ovr deleted the cubestore-queue-cancel-fix branch January 30, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant