Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include version in startup message #615

Merged
merged 12 commits into from
Apr 30, 2020

Conversation

jcw-
Copy link
Contributor

@jcw- jcw- commented Apr 24, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Includes the Cube.js version in the startup message:
image

The version is available in three places:

  1. CubejsServer.version()
  2. CubejsServerCore.version()
  3. const { version, port } = await cubejsServer.listen();

@jcw-
Copy link
Contributor Author

jcw- commented Apr 24, 2020

@paveltiunov curious what you think about doing something like this so the version is more discoverable (and also logged)? If this makes sense then I'll proceed to update the docs, examples, and guide content with the same change.

@paveltiunov
Copy link
Member

@jcw- Hey Jc! I think it's good idea! It would be great to move this version retrieval to method of server instance.

@codecov-io
Copy link

codecov-io commented Apr 25, 2020

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files          40       40           
  Lines        3316     3316           
=======================================
  Hits         2676     2676           
  Misses        640      640           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23da279...95fae18. Read the comment docs.

@jcw- jcw- marked this pull request as ready for review April 25, 2020 08:57
@paveltiunov
Copy link
Member

paveltiunov commented Apr 29, 2020

@jcw- Hey Jc! Looks good! We'd need just to resolve conflicts before merge. Could you please rebase your branch?

@jcw- jcw- force-pushed the include-version-in-startup-message branch from e49401f to 95fae18 Compare April 29, 2020 20:39
@jcw-
Copy link
Contributor Author

jcw- commented Apr 29, 2020

@paveltiunov conflicts resolved!

@paveltiunov paveltiunov merged commit d2f1732 into cube-js:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants