-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include version in startup message #615
feat: Include version in startup message #615
Conversation
@paveltiunov curious what you think about doing something like this so the version is more discoverable (and also logged)? If this makes sense then I'll proceed to update the docs, examples, and guide content with the same change. |
@jcw- Hey Jc! I think it's good idea! It would be great to move this version retrieval to method of server instance. |
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 40 40
Lines 3316 3316
=======================================
Hits 2676 2676
Misses 640 640 Continue to review full report at Codecov.
|
@jcw- Hey Jc! Looks good! We'd need just to resolve conflicts before merge. Could you please rebase your branch? |
e49401f
to
95fae18
Compare
@paveltiunov conflicts resolved! |
Check List
Description of Changes Made (if issue reference is not provided)
Includes the Cube.js version in the startup message:
The version is available in three places:
CubejsServer.version()
CubejsServerCore.version()
const { version, port } = await cubejsServer.listen();