fix(@cubejs-client/vue): Pivot config can use null from heuristics #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7167 +/- ##
===========================================
- Coverage 71.16% 47.04% -24.13%
===========================================
Files 322 155 -167
Lines 53630 20749 -32881
Branches 5216 5216
===========================================
- Hits 38165 9761 -28404
+ Misses 15148 10669 -4479
- Partials 317 319 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@DPHonys Thanks for contributing! Could you please add a test for it? |
…ry - Correctly updates pivot config after chart type change
|
Hi @paveltiunov, after multiple hours of getting empty pivotConfig I've found out I needed to use $nextTick to get updated properties so I hope the test is correctly composed. 🙂 |
|
@paveltiunov Also added the same fix and test to the Vue3 package. 🙂 |
…ery - Correctly updates pivot config after chart type change
DPHonys
force-pushed
the
fix-client-vue-builder-pivot-config
branch
from
0598608 to
a30f53b
Compare
This was referenced Dec 14, 2023
Open
This was referenced Dec 14, 2023
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
[#7166] Vue package ignores
nullvalue after herusicticsnull/undefinedfromdefaultHerusicticsmethod so the pivot config is not correctly updated and it behaves differently from it's React counterpart.Description of Changes Made (if issue reference is not provided)
defaultHerusicticsisundefinedthen we pass the current pivot config but if it isnullthen we pass thenullinto theResultSet.getNormalizedPivotConfigmethod.