Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Tableau Standard Gregorian missing date groupings supp… #7172

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Sep 26, 2023

…ort through SQL push down and some other functions

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

…ort through SQL push down and some other functions
@paveltiunov paveltiunov requested review from a team as code owners September 26, 2023 19:46
@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 8:07pm

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (a32b619) 71.16% compared to head (4ebea8c) 71.19%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7172      +/-   ##
==========================================
+ Coverage   71.16%   71.19%   +0.03%     
==========================================
  Files         322      323       +1     
  Lines       53630    53748     +118     
  Branches     5216     5216              
==========================================
+ Hits        38165    38266     +101     
- Misses      15148    15165      +17     
  Partials      317      317              
Flag Coverage Δ
cube-backend 47.04% <0.00%> (ø)
cubesql 86.38% <84.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 70.08% <ø> (ø)
rust/cubesql/cubesql/src/compile/mod.rs 93.41% <100.00%> (+0.02%) ⬆️
...l/cubesql/src/compile/rewrite/rules/wrapper/mod.rs 100.00% <100.00%> (ø)
rust/cubesql/cubesql/src/compile/test/mod.rs 93.33% <100.00%> (+0.10%) ⬆️
rust/cubesql/cubesql/src/transport/service.rs 91.80% <ø> (ø)
...ubejs-schema-compiler/src/adapter/BigqueryQuery.js 5.06% <0.00%> (ø)
.../src/compile/rewrite/rules/wrapper/udf_function.rs 97.67% <97.67%> (ø)
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 74.47% <85.71%> (+0.44%) ⬆️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 53.87% <0.00%> (-1.71%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 1339f57 into master Sep 26, 2023
@paveltiunov paveltiunov deleted the tableau-standard-gregorian branch September 26, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant